Add golang custom label sample #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
requested changes
Mar 8, 2023
There was a problem hiding this comment.
I am not super expert in GO but what I see looks simple and ok to me.
The folder renaming also looks good according to the conversations we had.
Perhaps I think what's missing is at least a README that explains:
- What is this
- How to run this - requirements for tools and AWS account
- Maybe a link about custom labels? What do you need to have a model/project running
- The usual disclaimer about the fact that you are responsible for cost, and, you should remember to stop your model once you are done otherwise you get billed for it!
|
Good feedback, thank you. I will add a README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds a Custom Labels sample using the Go language
The sample demonstrates using the
DetectCustomLabelsAPI. It outputs an image with the bounding boxes drawn around the image under inspection.There was an existing python sample under the
custom-labelsdirectory. I have moved this to apythonsubdirectory, and added agolangsibling directory.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.