Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AWSConfigRole is deprecated. The replacement policy is AWS_ConfigRole. #46

Merged

Conversation

watany-dev
Copy link
Contributor

※ReOpen PullRequest:#43
Follow the latest version of the IAM policy as the title suggests. The documents I referred to are as follows

https://docs.aws.amazon.com/config/latest/developerguide/security-iam-awsmanpol.html#security-iam-awsmanpol-AWS_ConfigRole

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).

@watany-dev
Copy link
Contributor Author

I put out a PR in the main branch of the forked branch, accidentally canceled it to create another PR, and closed # 43 without permission. I'm sorry to have taken your precious time.

@konokenj
Copy link
Contributor

Thank you for your contribution!

@konokenj
Copy link
Contributor

Changes look like good to merge, but git author information in commits is incorrect. You may fix and force-push it to record your contribution in our repo.

@watany-dev watany-dev force-pushed the hotfix/use-latest-version-iam-policy branch from d9bb03c to 91aa4a2 Compare May 11, 2022 15:02
@watany-dev
Copy link
Contributor Author

Now with git author information in the correct commit. Please check again.

@konokenj konokenj merged commit 47cadcc into aws-samples:main May 12, 2022
terayas pushed a commit to terayas/baseline-environment-on-aws that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants