Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update docs to use AWS SSO credential directly #73

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

ohmurayu
Copy link
Contributor

@ohmurayu ohmurayu commented Aug 31, 2022

This commit update docs to use AWS SSO credential without aws-wrap. This feature is available on CDK v2.18.0 and later.


By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).

@ohmurayu ohmurayu requested a review from wmikuriy August 31, 2022 10:17
@wmikuriy
Copy link
Contributor

wmikuriy commented Sep 2, 2022

LGTM!

Copy link
Contributor

@wmikuriy wmikuriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice modification and approve it

@wmikuriy wmikuriy enabled auto-merge September 2, 2022 06:05
@ohmurayu ohmurayu force-pushed the feature/awssso-credential branch from b5f9589 to d1c90b7 Compare September 2, 2022 06:31
@wmikuriy wmikuriy merged commit 121ea77 into aws-samples:main Sep 2, 2022
@ohmurayu ohmurayu deleted the feature/awssso-credential branch September 6, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants