Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when updating a stack when previous deployment has failed #4

Closed
mcripps9 opened this issue Apr 15, 2020 · 2 comments
Closed

Comments

@mcripps9
Copy link

After successfully deploying the solution, I made some changes to our template for the Audit account, redeployed, and it failed on the stack in our second region due to a dependency error. So, I fixed it and redeployed, but now the code build fails. I traced it down to the compare_template_and_params() function in sm_execution_manager.py. At line 156 it does a "return operation_status_flag" to indicate the template needs to be re-deployed, but the function is supposed to return two parameters, so it fails with a "ERROR","log_message": Unhandled Exception: cannot unpack non-iterable bool object}" at line 54 where it calls the compare_template_and_params() function. I think it needs to "return operation_status_flag, False". A similar situation also exists on line 176 for a different error.

@groverlalit
Copy link
Member

Thanks for opening the the pull request. We have added this to our backlog.

@rakshb
Copy link

rakshb commented Jul 8, 2020

@mcripps9 Hello! we have fixed this in CFCT V1.2

@leavertj leavertj closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants