Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New JSON format for v4.0 is not working #124

Closed
lithium-oxide opened this issue Jul 23, 2019 · 7 comments
Closed

New JSON format for v4.0 is not working #124

lithium-oxide opened this issue Jul 23, 2019 · 7 comments

Comments

@lithium-oxide
Copy link

Hi,

I've tried implementing an example of the JSON format (#113) for v4.0 of this solution. However, I cannot get an image to display: it simply returns a 404.

My example page is visible at http://18.207.186.243/ and you can see the image returns a 404.

The image object exists in the bucket at https://image-handler-testing.s3.amazonaws.com/subfolder/4simon.jpg

Any thoughts?

Some background:

I'm using the Serverless Image Handler on a number of production websites. In the last few days a slightly older version of the code seems to have stopped working due to issue #70. That problem was resolved in v4.0, which then gave rise to issue #112. The suggested workaround for that one seems to be using a JSON request, but now that gives rise to this issue. As I mentioned, this is in use on production websites and I'm urgently seeking some sort of resolution.

Thanks,
Conor

@soupy1976
Copy link

Hi Conor,

I had a similar problem (ie was using the old version in production and had to quickly update to the new version). In my case, it was because AWS updated the lambda execution environment which caused the old version to break.

I can't help you with your specific issue that you mention here, but I have managed to get the new v4.0 version working with the old Thumbor request style. In order to achieve it I had to fix the following

  • make it work with subfolders
  • add the security hash functionality
  • fix it so that it would provide webp automatically for browsers that support it
  • fix the way thumbor requests were translated into json requests

If you decide you want to go down the Thumbor request route, I could give you some pointers.

john

@lithium-oxide
Copy link
Author

lithium-oxide commented Jul 23, 2019

Hi John,

Yes, any pointers would be hugely appreciated. I want to stick with the Thumbor request route as far as possible, as there is a lot of code to change on the websites otherwise. Though ideally fixing #70 somehow would be the perfect solution, as that implementation is already deployed and in use in production systems.

Conor

@lithium-oxide
Copy link
Author

Thanks John. I've popped you an email.

Conor

@samlll42-github
Copy link

Same problem here :( production system down with older pre-v4 version because of underlying Lambda changes apparently. Also need to stick to Thumbor for now as UI changes would take more time... If you could post pointers on how to get v4 to work with thumbor without changes to the URL it would be great.

Thanks !

@soupy1976
Copy link

@samlll42-github @lithium-oxide

I have created a post on stackoverflow with some information on how I got the new version working with Thumbor style requests. Hope it is useful :-)

John.

@hayesry
Copy link
Member

hayesry commented Aug 4, 2019

Hey all, the patch for the Lambda Execution Environment update affecting v3.x has been published and is available at (#127): https://solutions-reference.s3.amazonaws.com/serverless-image-handler/v3.1.1/serverless-image-handler.template

Hope this resolves the issue!

@beomseoklee
Copy link
Member

We are closing this issue, but please feel free to open the issue again if you any other support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants