-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbor version forked and fixed to work on the latest lambda enviroment #127
Comments
Thank you! |
Is this working for other 3rd parties? I tried updating our template to the published one here and CFN complained with:
|
Same for me. Really need something to work asap. Multiple production
sites are failing right now.
Jason O Brown
…On Wed, Jul 24, 2019 at 11:39 AM Sean Coates ***@***.***> wrote:
Is this working for other 3rd parties? I tried updating our template to
the published one here and CFN complained with:
2019-07-24 12:30:51 UTC-0400 ServerlessImageHandler UPDATE_ROLLBACK_IN_PROGRESS The following resource(s) failed to update: [CustomResource].
2019-07-24 12:30:50 UTC-0400 CustomResource UPDATE_FAILED Error occurred while GetObject. S3 Error Code: NoSuchBucket. S3 Error Message: The specified bucket does not exist (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: REDACTED)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#127>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACCTAVQWVLBUSWSZ7UVDSSDQBCAUTANCNFSM4IGQ6ATA>
.
|
@jasonobrown which region are you deploying to ? |
@jodevsa us-east-2 |
I'm us-east-1, FWIW. |
Will it work if I deploy it in us-east-1 but my bucket is in us-east-2? |
@jasonobrown @scoates it should work now for us-east-1, us-east-2 and eu-west-1 |
Thank you. You saved the rest of the week. |
It still failed for me in us-east-2 |
Wrong bucket permission.., should work now 👍 |
Negative, failed again. I really appreciate the help by the way. Sorry to be such a nagging pain in the butt. |
To be clear for others who might be following: this is working for me, now, on an updated stack (previously updated in February!), deployed in |
I have a stack in I'd also like to nominate @jodevsa as person of the year! |
@jodevsa I'm seeing the same thing @jasonobrown is – failing in |
Hi guys @jasonobrown for some reason I'm unable to create a bucket in us-east-2 ( might be due to the fact i just deleted a bucket with that name in different region. I'll try again later working regions: I'll continue on supporting all regions when i come back |
@jodevsa you are a saint. Confirmed that |
Can anyone tell me why I can't launch in us-east-1? Am I supposed to be changing the template url to say us-east-1 or leaving it as eu-west-1? I've tried both, but obviously something is wrong. |
@jasonobrown Should be able to just leave the template url as |
@timkelty I've tried that. The bucket should be able to be in a different region right? |
@jasonobrown I am having the same issue as you. can not use us-east-1 as an origin. Seeing the rollback error. |
I just tried using a bucket in the same region and I'm still getting the error. I'm not setting an iam policy, but I didn't have one on the previous stack either (it's supposed to default to my user). Does that line up with what everyone else is doing (those who it has worked for)? |
I was able to deploy this to us-east-1 about an hour ago, but I can't anymore using the same steps. Not sure what's changed. |
Trying to deploy to us-east-1, I get this error. |
@jasonobrown what has been working for me is:
so far has worked for me in |
@dlosie @jasonobrown Not sure what changed. us-east-1 used to work |
@timkelty I'm working on ap-southeast-1, and this solution can not work. Can you please to give advice for that. Thank you! |
I am in the same situation... region is ap-southeast-2. Thanks! |
@jodevsa Could you help on other regions please. I have production on ap-southeast-1,. Thanks! |
I ran into the issue of my region not being supported the other day. I managed to figure out how to get it setup in my own S3 account and have the template pull from there.
|
I had changed the original template file, and when I check the old template and this new template I do not see much difference. Could you please explain which part is changed in the template so that I can change it manually? Is the change actually these two lines: |
@oakesjosh Hi, thanks for your solution. I have tried to update 135 & 136, 146 & 147, 160 & 161. put the 3 zip files under the root of the bucket directly. It says Error occurred while GetObject. S3 Error Code: NoSuchBucket. S3 Error Message: The specified bucket does not exist (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: blabla) Is there other things that I need to change? |
@oakesjosh I tried with your solution but I have the same issue like @chuyuou. So sad! |
I am having the same problem from eu-north-1 region. @jodevsa |
@oakesjosh my region is ap-southeast-2, The only difference between my template and the original template is the bucket name. |
@oakesjosh I am having the same problem. Did you change something else besides these? |
Just wanted to add that I was able to make this work by: I got similar errors like the above 'NoSuchBucket'... The critical bit was the first 2 Parameters of the template:
I used the supplied template as is, including the following bucket and key for the image handler code:
Next I plan to point it to my own bucket, so that I am not dependent on this 3rd party resource that I don't have control over. Edit: will follow instructions by @oakesjosh above and see if this can work with the S3 bucket and the zip files within my infrastructure in ap-southeast-2. Edit: Yes I can confirm that @oakesjosh instructions above worked for me: Image Handler is deployed in ap-southeast-2 as @chuyuou said:
The only issues I had was not having the correct bucket policy to allow CF to get the zip files from my bucket 1. Thanks! |
Not working for eu-west-3:
Please advice. Edit: Fixed following @oakesjosh instructions. |
Thanks @timkelty, worked for me on us-west-2 |
Worked out..Thanks @oakesjosh ! This can work!! Saved my tomorrow!! |
@chuyuou Did you do something else rather than changing the bucket names? |
for example, {bucket-name}-ap-southeast-2 in s3, then in the template the Origin S3 Bucket should written as :{bucket-name} , without region..Follow @oakesjosh instruction and use those three zip files. |
@chuyuou You save my life! |
I'm getting this error
|
Thanks a lot for the fix @jodevsa! |
Hello all - This version of the solution has been patched and is now available at: |
@hayesry Thank you! Solved the problem on us-west-2. |
In case anyone else is managing their own template based on the original template: the only fix I needed in my template was to switch all instances of "3.1.0" to "3.1.1". This will target the correct solution image handler zip. |
@hayesry Can you share the updated build process? The new solution does not work for us since we have to support animated GIFs :( Note: I have already updated my fork (including Docker build), for those who like to do the builds themselves (I am not using CF). Thanks to @jodevsa for sharing the correct value for |
@hayesry Thank you for linking that! I used that template with the steps in #127 (comment) and it solved the issue for me. VERY MUCH appreciate it! |
This entire section https://github.com/awslabs/serverless-image-handler#building-distributable-for-customization should be removed until any sort of semblance of a deterministic build can be achieved. You can brick you entire deployment by simply changing a Tag value and end up replacing your imagehandler function with an architecture that is unsupported. It will allow you do that without a peep from the build process. My current strategy is deploy the solution, and drift the stack while documenting the changes. To upgrade, I redeploy the solution, reapply my drift, then adjust my dns aliases. I'd be thrilled with just an AMI of environment aws solutions team uses to build https://aws.amazon.com/solutions/serverless-image-handler/ Also thinking of ways to completely decouple the lambda function from this stack completely, way to much risk exposure building image libraries. |
We are closing this issue, but please feel free to open the issue again if you any other support. |
Since AWS have updated the lambda execution environment which broke old deployments (versions <=3.0) of this solution, and newer versions of this solution doesn't correctly implement the Thumbor interface (they shifted to sharpJS). I decided to Fork version 3.1 (Thumbor version) and make the required changes for it to work on lambda again
https://github.com/jodevsa/serverless-image-handler
Published solution template is available in the README
The text was updated successfully, but these errors were encountered: