Node 10.x

[jedsmith13]

Issue #, if available: 156

Description of changes: Adjusted the template to use nodejs10.x and updated sharp

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[OBrown92]

Do you test it? I think it won't work because there are breaking changes like new Buffer with Stability: 0. If i set my running Version to 10.x, it will get me a internal Server Error.

[jedsmith13]

The currently hosted version of the serverless image handler uses a version of sharp built for NodeJS 8. To get it to work you have to rebuild sharp for Node 10. After my few minor changes are made you will have to follow the instructions for deploying your own custom build found in the readme. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Leon Braun <[email protected]> Sent: Thursday, October 24, 2019 5:42:49 AM To: awslabs/serverless-image-handler <[email protected]> Cc: Jed Smith <[email protected]>; Author <[email protected]> Subject: Re: [awslabs/serverless-image-handler] Node 10.x (#157) Do you test it? I think it won't work because there are breaking changes like new Buffer with Stability: 0. If i set my running Version to 10.x, it will get me a internal Server Error. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#157>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAE5QTBIEDONQXOY6KZJUK3QQGC3TANCNFSM4JDFDQNA>.

[OBrown92]

Nice, I will try. Just took a quick look a few days ago and found these issues, seems to be fixed with the sharp upgrade.

[jedsmith13]

@OBrown92 Also while following the custom build I had to follow this comment. If you run into issues with not being able to find to your bucket with the source code when you run your cloud formation template, that comment helped me.

[OBrown92]

Thanks, I try to create a zip file like the one from ilove because I also need the changes. Unfortunately it won't work by now.

[jedsmith13]

@OBrown92 Sorry, I don't know anything about ilove's build. I would suggest you contact the maintainer of that project if you want help with it.

[mberneis]

@jedsmith13 - Could you share your template URL of a successful build? -- I am facing issues creating a proper cloud formation build (#115 (comment))

[jedsmith13]

I didn't upload my template to S3 I just uploaded it when I created a new cloud formation instance. I just uploaded a copy though I don't know how long I will keep the image-handler.zip file on the S3 bucket. I figure the AWS one will get updated in the next month or two and if not I will probably customize the one I use some.

[mberneis]

I could not run a cloud-formation with your template - bucket not found - I guess the code bucket does not exist anymore. - At this point I will wait a month to see if AWS updates their solution - otherwise back to debugging!

[beomseoklee]

Thanks for the pull request, and we are trying to update the solution to support Node.js 10.x in this year.

[georgebearden]

Hi All - This solution has been updated to a later version of Node. Please let us know if you need additional assistance.

[rpong]

Thanks, I try to create a zip file like the one from ilove because I also need the changes. Unfortunately it won't work by now.

Hope this helps, releasing the same pre-package we are using for Node 12.x.

https://github.com/innovationlove/serverless-image-handler/releases/tag/4.0.3

Unfortunately though, we are using Sharp 0.22 instead of 0.23, there are some cropping/fitting behaviour in 0.23 that is different with 0.22 that we have not looked into yet.

Example: dimensions such as 150x0 work with 0.22, but fails in 0.23. We will look into it soon and try to share our changes.

[mberneis]

Had the same issue with resizing proportinally by setting 0 to one dimension. - Figured out it works if you specify null instead of 0