Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom headers #182

Closed
wants to merge 2 commits into from
Closed

Conversation

bretto36
Copy link

@bretto36 bretto36 commented Feb 6, 2020

I'm trying to use the serverless image handler in our work environment but it doesn't seem to provide any cache mechanism.

The solution is either pass along the Cache headers from S3 (we didn't set any when initially uploading the files). We could update the S3 meta data, or we could pass in the headers we want into the base64 string. This allows for much more customisation. Cache Control, Content Type headers.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated to Version 4.1.
…ethod. This allows you to specify max age/expires/content type etc
@beomseoklee
Copy link
Member

Thanks for your opinion, @bretto36
We would definitely take a look at this one.

@beomseoklee
Copy link
Member

@bretto36 can you provide more examples of custom headers you would like to add?

@beomseoklee
Copy link
Member

Thanks for your contribution, @bretto36
We've added this feature to v5.1.0. Unfortunately, due to the internal policy, we don't merge the PR directly. You can see the detail in CHANGELOG and your name in README

Once again, thanks for your contribution.

@bretto36
Copy link
Author

Merged in through separate commit as public contributions can’t be added.
https://github.com/awslabs/serverless-image-handler/blob/master/CHANGELOG.md See 5.1.0

@bretto36 bretto36 closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants