Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --recursive from instructions #255

Closed
wants to merge 1 commit into from

Conversation

makoncline
Copy link

I was getting the error Unknown options: --recursive when running lines 67 and 68 of the readme with aws-cli/2.1.15.
When the --recursive option is removed, the command works.

Issue #, if available:

Description of changes:

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

with `aws-cli/2.1.15` i was getting the error `Unknown options: --recursive` when running lines 67 and 68.
When the `--recursive` option is removed, the command works
@beomseoklee
Copy link
Member

@makoncline Thanks for your feedback. We'll update README.md in the next release.

@8secz-johndpope
Copy link

yes - I had to skip this step. Otherwise smooth.
There's no mention of crafting the url eg
/200x200/image.jpg

I came here from another repo - I was sure it did it - now I can't find the instructions anywhere.

sagidM/s3-resizer#21

Let's say we have some shared image in S3, for example:
https://example.com/images/pretty_photo.jpg

to resize on fly this image to, say, 150x150, we can make a request like this:
https://example.com/images/150x150/pretty_photo.jpg

@G-Lenz
Copy link
Contributor

G-Lenz commented Jan 29, 2021

We have updated README.md in v5.2.0.

@beomseoklee
Copy link
Member

Thanks for your contribution, and this was added in the current version.
Because of our internal policy, we couldn't merge the PR directly so we put your name as a contributor in https://github.com/aws-solutions/serverless-image-handler#external-contributors.

Once again, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants