Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (unit tests): add unit tests for crop #459

Closed
wants to merge 1 commit into from
Closed

chore (unit tests): add unit tests for crop #459

wants to merge 1 commit into from

Conversation

dougtoppin
Copy link
Contributor

@dougtoppin dougtoppin commented Mar 23, 2023 •
edited
Loading

Description of changes:

  • add unit test to increase code coverage
  • fix issue where an existing unit test was incorrectly using the crop function
  • add unit test to confirm current behavior

Checklist

  • 👋 I have added unit tests for all code changes.
  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:codeql/language:javascript. As part of the setup process, we have scanned this repository and found 7 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:codeql/language:typescript. As part of the setup process, we have scanned this repository and found 7 existing alerts. Please check the repository Security tab to see all alerts.

@dougtoppin dougtoppin marked this pull request as ready for review March 24, 2023 19:36
@dougtoppin dougtoppin requested review from G-Lenz and schana March 24, 2023 20:41
fisenkodv
fisenkodv previously approved these changes Mar 28, 2023
View reviewed changes
@dougtoppin dougtoppin requested a review from gsingh04 March 28, 2023 22:50
G-Lenz
G-Lenz previously approved these changes Mar 29, 2023
View reviewed changes
source/image-handler/test/image-handler/crop.spec.ts Outdated Show resolved Hide resolved
Add unit test for crop, prettier on crop test, Remove unneeded try/ca…
99eecdd 
…tch in image-handler test, update snapshot, change unit test to re-use the new base64 image string
@dougtoppin dougtoppin dismissed stale reviews from G-Lenz and fisenkodv via 99eecdd April 11, 2023 14:25
@simonkrol simonkrol closed this Feb 9, 2024
@simonkrol simonkrol mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Lenz G-Lenz G-Lenz left review comments

@gsingh04 gsingh04 gsingh04 requested changes

@fisenkodv fisenkodv fisenkodv left review comments

@schana schana Awaiting requested review from schana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dougtoppin @fisenkodv @gsingh04 @G-Lenz @simonkrol