Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation not preserved to GIFs in case of AUTO_WEBP #511

Conversation

vaniyokk
Copy link

@vaniyokk vaniyokk commented Oct 12, 2023

Issue #456

Description of changes:
Add WEBP ContentTypes.WEBP to list of formats that supports animation (and should preserve animation on compressed image)

Checklist

  • 👋 I have added unit tests for all code changes.
  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dougtoppin
Copy link
Contributor

@vaniyokk Thank you for your submission. We will evaluate the change and get back to you.

@simonkrol
Copy link
Member

Hi @vaniyokk

We've finished evaluating this change and have decided to include it in the next minor/major release. To avoid affecting existing deployments, the current plan is that overriding whether an image should be animated will be done with /filters:animated(true/false) or edits: { animated: true }, which will override the existing GIF type check (maintaining the existing behaviour if the animated filter is not provided).
While our internal processes have us merge the code manually, once the release with this change is out, you'll see yourself included in the external contributors section towards the bottom of the readme and this PR will be closed.

Thanks for your contributions,
Simon

@simonkrol
Copy link
Member

Change has been included in v6.2.6, thanks for your contributions :)

@simonkrol simonkrol closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants