engine: use getters instead of accessing unsafe task states directly

aws · Apr 10, 2017 · 5da2ac5 · 5da2ac5
1 parent bfa0954
commit 5da2ac5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/agent/engine/docker_task_engine.go b/agent/engine/docker_task_engine.go
@@ -311,7 +311,7 @@ func (engine *DockerTaskEngine) emitTaskEvent(task *api.Task, reason string) {
 	if !taskKnownStatus.BackendRecognized() {
 		return
 	}
-	if task.SentStatusUnsafe >= taskKnownStatus {
+	if task.GetSentStatus() >= taskKnownStatus {
 		log.Debug("Already sent task event; no need to re-send", "task", task.Arn, "event", taskKnownStatus.String())
 		return
 	}

diff --git a/agent/engine/task_manager.go b/agent/engine/task_manager.go
@@ -129,7 +129,7 @@ func (mtask *managedTask) overseeTask() {
 	for {
 		// If it's steadyState, just spin until we need to do work
 		for mtask.steadyState() {
-			llog.Debug("Task at steady state", "state", mtask.KnownStatusUnsafe.String())
+			llog.Debug("Task at steady state", "state", mtask.GetKnownStatus().String())
 			maxWait := make(chan bool, 1)
 			timer := mtask.time().After(steadyStateTaskVerifyInterval)
 			go func() {
@@ -144,7 +144,7 @@ func (mtask *managedTask) overseeTask() {
 			}
 		}
 
-		if !mtask.KnownStatusUnsafe.Terminal() {
+		if !mtask.GetKnownStatus().Terminal() {
 			// If we aren't terminal and we aren't steady state, we should be able to move some containers along
 			llog.Debug("Task not steady state or terminal; progressing it")
 			mtask.progressContainers()
@@ -158,7 +158,7 @@ func (mtask *managedTask) overseeTask() {
 		if err != nil {
 			llog.Warn("Error checkpointing task's states to disk", "err", err)
 		}
-		if mtask.KnownStatusUnsafe.Terminal() {
+		if mtask.GetKnownStatus().Terminal() {
 			break
 		}
 	}