Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent errors and does not clean-up 'dangling' images #2017

Closed
sparrc opened this issue May 3, 2019 · 1 comment
Closed

Agent errors and does not clean-up 'dangling' images #2017

sparrc opened this issue May 3, 2019 · 1 comment

Comments

@sparrc
Copy link
Contributor

sparrc commented May 3, 2019 •
edited
Loading

Summary

The Agent is not able to cleanup 'dangling' images (docker images -f dangling=true). These are image IDs that do not have any tags. They will show up in docker images with name <none>:<none>

The issue is that the image manager lists all images by name, then attempts to inspect each image based on the name. Dangling images with name none throw an error on image inspection and will never get cleaned up.

Solution could be to list images by ID, then determine exclusions after inspecting the image.

Supporting Log Snippets

When a customer has a dangling image, they will see error messages like this in the logs:

2019-05-03T17:50:11Z [ERROR] Error inspecting non-ECS image name: <none>:<none> - Error response from daemon: no such image: <none>:<none>: invalid reference format
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 7, 2019
@sparrc
image manager: fix image cleanup corner cases
d1dd495 
closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 7, 2019
@sparrc
image manager: cleanup dangling images
d3652ba 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
@sparrc sparrc mentioned this issue May 7, 2019
Merged
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 7, 2019
@sparrc
image manager: cleanup dangling images
c442bfb 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
@sparrc sparrc changed the title Agent does not clean up 'dangling' images Agent errors and does not clean-up 'dangling' images May 8, 2019
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 15, 2019
@sparrc
image manager: cleanup dangling images
f2ad52b 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 16, 2019
@sparrc
image manager: cleanup dangling images
4e4300a 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 21, 2019
@sparrc
image manager: cleanup dangling images
43c488e 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 22, 2019
@sparrc
image manager: cleanup dangling images
7dfcc8d 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 22, 2019
@sparrc
image manager: cleanup dangling images
0d0c548 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 22, 2019
@sparrc
non-ECS image cleanup: cleanup dangling images
a2a66d0 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 22, 2019
@sparrc
non-ECS image cleanup: cleanup dangling images
57d0e60 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
sparrc added a commit to sparrc/amazon-ecs-agent that referenced this issue May 23, 2019
@sparrc
non-ECS image cleanup: cleanup dangling images
22fa19a 
Use ImageID to cleanup images rather than tag name, to guarantee that we
are passing a legitimate identifier to InspectImage and RemoveImage.

closes aws#2017
@sparrc
Copy link
Contributor Author

sparrc commented May 23, 2019

closed by #2023

@sparrc sparrc closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sparrc