Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent reports incorrect capabilities on windows #2035

Closed
petderek opened this issue May 10, 2019 · 4 comments
Closed

Agent reports incorrect capabilities on windows #2035

petderek opened this issue May 10, 2019 · 4 comments
Labels
kind/bug

Comments

@petderek
Copy link
Contributor

Summary

Agent running on windows reports capabilities that won't work on windows.

Description

Following capabilites aren't supported on windows:

ecs.capability.aws-appmesh
ecs.capability.pid-ipc-namespace-sharing
ecs.capability.task-eia
@petderek
Copy link
Contributor Author

We should also double check this:

ecs.capability.docker-plugin.local

Can't remember if docker uses the 'local' plugin or a different code path for windows volumes.

@yhlee-aws
Copy link
Contributor

Windows does not support Docker plugins, or at least it didn't at the time of Docker Volume Plugin project. Only docker volume supported on Windows is local.

@petderek
Copy link
Contributor Author

petderek commented May 13, 2019 •
edited
Loading

Only docker volume supported on Windows is local

sweet, so thats probably fine to leave in.

mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue May 31, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
e9d0780
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue May 31, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
9bf17bb
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
382dfa1
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
e2a30c3
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
4bf4cae
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
a1b4ffa
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
0a109ef
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 4, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
5e131a7
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 5, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
632a9ab
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 5, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
83baa2e
@mssrivas mssrivas mentioned this issue Jun 5, 2019
Merged
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 5, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
adb228f
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 5, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
17665e0
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 5, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
6b77b00
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 6, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
9a2bf9b
mssrivas added a commit to mssrivas/amazon-ecs-agent that referenced this issue Jun 7, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (aws#2035)
453fb8f
mssrivas added a commit that referenced this issue Jun 7, 2019
@mssrivas
Fixing Agent reports incorrect capabilities on windows (#2035)
71b5b08
@mssrivas
Copy link
Contributor

Implemented as part of pull #2070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petderek @yhlee-aws @ubhattacharjya @mssrivas