Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Docker >= 1.13.0 on Windows #729

Closed
samuelkarp opened this issue Mar 13, 2017 · 11 comments
Closed

Support for Docker >= 1.13.0 on Windows #729

samuelkarp opened this issue Mar 13, 2017 · 11 comments

Comments

@samuelkarp
Copy link
Contributor

Docker 1.13.0 on Windows dropped support for the 1.17 API version used by the ECS agent. Supporting Docker >= 1.13.0 on Windows means moving to an API >= 1.24. There are many differences between 1.17 and 1.24, and we'll need to maintain both codepaths in order to continue supporting Docker < 1.12.0 on Linux. Of particular concern are the changes involving the Config and HostConfig in Docker's CreateContainer and StartContainer APIs as well as the structure of information returned through Inspect calls. Because some of the Config and HostConfig content is generated by the ECS backend, we'll need to make changes there as well as in the agent in order to support Docker >= 1.13.0 on Windows.

@samuelkarp
Copy link
Contributor Author

Support for old APIs was removed in moby/moby#27908.

@sentientmonkey
Copy link
Contributor

sentientmonkey commented Mar 13, 2017 via email

@samuelkarp
Copy link
Contributor Author

samuelkarp commented Mar 13, 2017 via email

@panmanphil
Copy link

Any update on this? The current version of docker on windows doesn't even support docker stats so autoscaling groups don't work.

@samuelkarp
Copy link
Contributor Author

@panmanphil This is currently being worked on in #783.

@samuelkarp
Copy link
Contributor Author

An update here: while we've been working on support for newer API versions, we've run into some issues with pulling the microsoft/windowsservercore:latest image with the newer API version. We're holding off on releasing a new agent for Windows until we've addressed these issues.

@JonCubed
Copy link

As mentioned in #942 the latest Windows Core With Containers AMI (image name: Windows_Server-2016-English-Core-ContainersLatest-2017.08.09, Ami Id: ami-4a16f432) is running a non-supported version of docker. Does this mean that we will need to stick with Windows_Server-2016-English-Core-Containers-2017.08.09 (Ami Id: ami-ad1afad5) going forward until the agent can support later versions of docker?

@EmmanuelTsouris
Copy link

@JonCubed, we created the new Windows_Server-2016-English-Core-ContainersLatest-* AMI for customers who would like to have the latest released version of Docker. Since the AMI is built monthly (to pick up Windows patches), the idea here is that it will also pick up whatever version of Docker is released. The version is the same one you get from installing the Docker package:
Install-Package -Name docker -ProviderName DockerMsftProvider

Windows_Server-2016-English-Core-Containers-* will continue to have the version of Docker that is compatible with ECS.

@JonCubed
Copy link

@EmmanuelTsouris thanks for explaining the difference between the AMIs

@samuelkarp
Copy link
Contributor Author

samuelkarp commented Sep 25, 2017

As I mentioned in #729 (comment), we were investigating a bug with pulling microsoft/windowsservercore:latest. We've now identified the bug as relating to logic intended to skip pulls for some containers.

#990 should fix this bug.

@samuelkarp
Copy link
Contributor Author

We've released ECS agent v1.14.5, which now works with newer versions of Docker on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants