Dependency Condition Naming change: #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhlee-aws
reviewed
Feb 24, 2019
| // CreateCondition ensures that a container progresses to next state only when dependency container has started | ||
| createCondition = "START" | ||
| // StartCondition ensures that a container progresses to next state only when dependency container is running | ||
| startCondition = "RUNNING" |
There was a problem hiding this comment.
Should these be
createCondition = "CREATE"
StartCondition = "START"
yhlee-aws
reviewed
Feb 24, 2019
| // SuccessCondition ensures that a container progresses to next state only when | ||
| // dependency container has successfully completed with exit code 0 | ||
| successCondition = "SUCCESS" | ||
| // CompleteCondition ensures that a container progresses to next state only when dependency container has completed | ||
| completeCondition = "COMPLETE" | ||
| // StartCondition ensures that a container progresses to next state only when dependency container is healthy | ||
| // HealthymCondition ensures that a container progresses to next state only when dependency container is healthy |
There was a problem hiding this comment.
HealthyCondition not HealthymCondition
* "START" Dependency condition has been changed to "CREATE" as it waits for the dependency to atleast get created * "RUNNING" Dependency Condition has been changed to "START" as it waits for the dependency to get started.
ubhattacharjya
force-pushed
the
Naming
branch
from
a9b9a0e to
4ac84e4
Compare
petderek
approved these changes
Feb 24, 2019
yhlee-aws
approved these changes
Feb 24, 2019
|
We validated that the arm integ test is passing manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.