ACS Model change for container ordering #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumex93
reviewed
Feb 24, 2019
agent/acs/model/api/api-2.json
Outdated
| "type":{"shape":"ProxyConfigurationType"}, | ||
| "containerName":{"shape":"String"}, | ||
| "properties":{"shape":"StringMap"} | ||
| } |
There was a problem hiding this comment.
Please only includes changes that related to ur feature. Normally we only update changes related to our own features when we update acs model.
ubhattacharjya
force-pushed
the
ACS
branch
3 times, most recently
from
7547184 to
d8fc073
Compare
suneyz
approved these changes
Feb 25, 2019
|
please take a look at why integ and functional tests are failing |
|
I'm investigating why windows tests are failing. It looks like the dependency tests are failing and it isn't clear why |
This should eventually make windows tests faster to run. Fixes a bug where task context cancel causes an infinite steady state loop. Previously if the context expired, waitSteady() will spin forever since the timeout no longer works. This introduces a check for context expiration earlier in the code.
|
We've isolated the reason for windows tests failing: the windows containers are too resource constrained. We will open a separate PR to address this. |
petderek
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ACS Model change for container ordering
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.