Fixed #2086 by adding support for Windows Named Pipes in volumes #2185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes issue #2086, allowing Windows containers to mount Named Pipes (i.e. Mounting the .\pipe\docker_engine).
Implementation details
There is a regular expression to check if the mount path is using named pipes, is so, it bypasses the call to the filepath.Clean function that breaks the named pipes path.
Testing
I ran the unit and integration tests on a Windows machine
New tests cover the changes: yes
Description for the changelog
Enables support for mounting named pipes to Windows docker containers in ECS
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.