Added ECS_ENABLE_SPOT_INSTANCE_DRAINING to README #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
reviewed
Sep 16, 2019
README.md
Outdated
| @@ -178,6 +178,7 @@ additional details on each available environment variable. | |||
| | `ECS_EXCLUDE_UNTRACKED_IMAGE` | `alpine:latest` | Comma seperated list of `imageName:tag` of images that should not be deleted by the ECS agent if `ECS_ENABLE_UNTRACKED_IMAGE_CLEANUP` is enabled. | | | | |||
| | `ECS_DISABLE_DOCKER_HEALTH_CHECK` | `false` | Whether to disable the Docker Container health check for the ECS Agent. | `false` | `false` | | |||
| | `ECS_NVIDIA_RUNTIME` | nvidia | The Nvidia Runtime to be used to pass Nvidia GPU devices to containers. | nvidia | Not Applicable | | |||
| | `ECS_ENABLE_SPOT_INSTANCE_DRAINING` | `true` | If true, if the container instance receives a [spot interruption notice](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/spot-interruptions.html), agent will set the instance's status to [DRAINING](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/container-instance-draining.html), which gracefully shuts down and replaces all tasks running on the instance. It is recommended that this be set to `true` when using spot instances. | `false` | `false` | | |||
There was a problem hiding this comment.
*replaces tasks as part of service
There was a problem hiding this comment.
👍, modified sentence to indicate that only tasks that are part of a service are replaced
sparrc
force-pushed
the
spot-draining-readme
branch
from
f5c7125 to
e4d44c7
Compare
sparrc
force-pushed
the
spot-draining-readme
branch
from
e4d44c7 to
43df207
Compare
yhlee-aws
approved these changes
Sep 17, 2019
sharanyad
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2205
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.