Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pullImageTimeout configurable #2565

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

ubhattacharjya
Copy link
Contributor

@ubhattacharjya ubhattacharjya commented Aug 12, 2020

Summary

This code change makes the image pull timeout configurable. The default timeout if not mentioned is 2h for both linux and windows. However by mentioning the environment variable ECS_IMAGE_PULL_TIMEOUT in ecs.config file you can configure the timeout according to your wish

Implementation details

Testing

Unit tests cover changes
Tested the following manually on AL2, AL1 and windows instance:

  1. If not mentioned, default timeout is getting considered.
  2. If mentioned, the new timeout is getting considered.
  3. If mentioned to a really small value, the docker image pull process is correctly timing out and the task fails

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ubhattacharjya ubhattacharjya requested a review from a team August 12, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants