Fix a deadlock scenario in envfiles usage #2569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for the contribution, rather than keeping the deferred unlock and creating a new "unsafe" function, could you change the implementation to just Unlock after the lock is not used anymore? I believe something like this would avoid the deadlock: 913e3b5 |
saich
force-pushed
the
fix/envfiles-deadlock
branch
from
efa970f to
31d0fa0
Compare
saich
force-pushed
the
fix/envfiles-deadlock
branch
from
31d0fa0 to
f9bfa5c
Compare
|
Hey @sparrc, thanks for the feedback. Incorporated your suggestion. |
|
The tests seems to be failing on Travis CI because of an unrelated issue, and seems like an intermittent issue. Appreciate if anyone can restart the tests. |
yhlee-aws
approved these changes
Aug 18, 2020
mssrivas
approved these changes
Aug 18, 2020
mythri-garaga
approved these changes
Aug 18, 2020
|
We have created new PR with your fix here: #2580 to better manage the PR with some testing issues we are seeing at the moment (we are actively working on unblocking it). Please track this fix through the new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a deadlock scenario when the agent restores the state from its data file and the tasks are using environment files feature
Implementation details
The issue happens in some particular cases where the system waits indefinitely to lock a lock, which it itself has locked it, and hasn't unlocked yet, resulting in a deadlock.
Testing
New tests cover the changes: no
Description for the changelog
Bug - Fixed a bug that could cause a deadlock resulting in the agent not functioning as expected
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.