logger: change loglevel behavior #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenxiong
reviewed
Aug 28, 2020
fenxiong
approved these changes
Aug 28, 2020
mythri-garaga
approved these changes
Aug 28, 2020
cyastella
approved these changes
Aug 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes behavior of ECS_LOGLEVEL to control the level of logging for both the logging driver and the on instance file unless ECS_LOGLEVEL_ON_INSTANCE is set to override it. ECS_LOGLEVEL_ON_INSTANCE defaults to off if a logging driver is set, or it defaults to the value of ECS_LOGLEVEL if not.
Implementation details
The behavior for interactions between ECS_LOG_DRIVER, ECS_LOGLEVEL, and ECS_LOGLEVEL_ON_INSTANCE is as follows (default level is info):
Set LOGLEVEL: driver level = ECS_LOGLEVEL, instance level = ECS_LOGLEVEL
Set LOGLEVEL_ON_INSTANCE: driver = default, instance = LOGLEVEL_ON_INSTANCE
Set both: driver = ECS_LOGLEVEL, instance = LOGLEVEL_ON_INSTANCE
Set LOGLEVEL + LOG_DRIVER: driver = ECS_LOGLEVEL, instance = off
Set LOGLEVEL_ON_INSTANCE + LOG_DRIVER: driver ; default, instance = LOGLEVEL_ON_INSTANCE
Set Both + Driver: driver: LOGLEVEL, instance: LOGLEVEL_ON_INSTANCE
Set just LOG_DRIVER: driver = default, instance = off
Set none of them: driver = default, instance = default
Testing
Added a unit test to test the interactions between the variables above and manually tested all combinations by setting the variables and checking the logs.
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.