Adds better logging around SMB mapping for FSX #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsiddharth - Can you give me some feedback on this. |
vsiddharth
reviewed
Jun 6, 2022
agent/taskresource/fsxwindowsfileserver/fsxwindowsfileserver_windows.go
Outdated
Show resolved
Hide resolved
agent/taskresource/fsxwindowsfileserver/fsxwindowsfileserver_windows.go
Outdated
Show resolved
Hide resolved
jterry75
force-pushed
the
add_fsx_windows_logging
branch
from
c2b5806 to
4e6e7a9
Compare
vsiddharth
previously approved these changes
Jun 8, 2022
1. Adds debug logging for SMB mapping for the command that is being executed. This command will not not log the creds used to attach the mapping. 2. Logs the ps output stderr/stdout from the command on error. Signed-off-by: Justin Terry <[email protected]>
jterry75
force-pushed
the
add_fsx_windows_logging
branch
from
4e6e7a9 to
a64580a
Compare
|
New output: |
singholt
reviewed
Jun 9, 2022
singholt
approved these changes
Jun 9, 2022
fierlion
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging for SMB mapping for the command
that is being executed. This command will not not log the
creds used to attach the mapping.
Logs the ps output stderr/stdout from the command on error.
Signed-off-by: Justin Terry [email protected]
Implementation details
Added the logging around the PowerShell exec.
Testing
Have verified that in both the debug cmdline and the output it doesnt log the password.
Description for the changelog
Adds command and error logging for FSx file mapping when calling out to PowerShell.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.