Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs-init build tag argument in integrated spec files #3324

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

fierlion
Copy link
Member

@fierlion fierlion commented Aug 1, 2022

Summary

This adds the build tag to the ecs-init gobuild.sh script, which will point to the correct ecs-init config
https://github.com/aws/amazon-ecs-init/blob/5f7f9336bc3c5314206aefd212e9ebbfc3bdab60/ecs-init/config/config_al2.go#L1

Implementation details

the tags are already defined in the spec files, this was just a miss in our setup/testing.

Testing

Built using make generic-rpm-integrated on a fresh instance of latest ecs-optimized AMI.

sudo systemctl stop ecs
sudo rpm -e <old rpm file>
sudo rpm -i <built rpm file>
sudo systemctl start ecs

then a docker inspect of the launched agent container to be sure we see:

            {
                "Type": "bind",
                "Source": "/sys/fs/cgroup",
                "Destination": "/sys/fs/cgroup",
                "Mode": "",
                "RW": true,
                "Propagation": "rprivate"
            },

Description for the changelog

Fix ecs-init build tag bug for integrated builds.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fierlion fierlion changed the base branch from master to dev August 1, 2022 22:02
Copy link
Contributor

@YashdalfTheGray YashdalfTheGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this!

@fierlion fierlion merged commit b3f213a into aws:dev Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants