Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners file; update token permission to read only for workflow #3374

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

mythri-garaga
Copy link
Contributor

@mythri-garaga mythri-garaga commented Sep 2, 2022

Summary

This PR includes changes -

  1. Added codeowners file to this repository.
    https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
  2. Reduced the token permission to read only by setting the the permission directive to read for workflows
  3. Use a regular expression and validation to make sure that the GO_VERSION is of the correct format and length

Implementation details

Testing

Workflow logs shows correct Go version being used

Setup go stable version spec 1.18.3
Attempting to download 1.1[8](https://github.com/aws/amazon-ecs-agent/runs/8234162562?check_suite_focus=true#step:4:9).3...
matching 1.18.3...

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mythri-garaga mythri-garaga marked this pull request as draft September 6, 2022 19:03
@mythri-garaga mythri-garaga changed the title Add codeowners file [WIP] Add codeowners file Sep 6, 2022
@mythri-garaga mythri-garaga changed the title [WIP] Add codeowners file Add codeowners file; update token permission to read only for workflow Sep 7, 2022
@mythri-garaga mythri-garaga marked this pull request as ready for review September 7, 2022 17:49
sparrc
sparrc previously approved these changes Sep 7, 2022
.github/workflows/linux.yml Outdated Show resolved Hide resolved
and validate GO_VERSION is of the correct format and length
@fierlion fierlion merged commit ce40ba1 into aws:dev Sep 8, 2022
@chienhanlin chienhanlin mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants