Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env with required path for appmesh integration. #3378

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

fierlion
Copy link
Member

@fierlion fierlion commented Sep 6, 2022

Summary

Pulling this change forward:
Newer version of Docker mounts tini to /sbin/init which conflicts our existing /sbin:/sbin mount. Updating the mount to /sbin:/host/sbin and adds /host/sbin to the PATH env (needed by the appmesh plugin to find the iptable binary) fixes the problem.
0a5c60c

Implementation details

Added the path to the agent-config.json to build into the ECS Agent container image.

Testing

built the ecs-agent image using make dockerfree-agent-image
loaded the new image with docker load < docker load < ecs-agent-v1.62.2.tar
docker inspect <loaded image ID> shows:

        "Config": {
            ...
            "Env": [
                "PATH=/host/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
            ],
            ...

New tests cover the changes: no

Description for the changelog

Add appmesh path to agent container image config.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fierlion fierlion merged commit ccca47c into aws:dev Sep 6, 2022
@fierlion fierlion deleted the fierlion/addPathEnv branch September 6, 2022 22:09
@chienhanlin chienhanlin mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants