Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.19.1 #3398

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Bump Go version to 1.19.1 #3398

merged 5 commits into from
Sep 26, 2022

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Sep 22, 2022

Pickup the fix for https://nvd.nist.gov/vuln/detail/CVE-2022-27664

Most of this is whitespace and comment changes, which are due to changes in go 1.19 go fmt, which now formats comments for the sake of the documentation, see https://tip.golang.org/doc/go1.19#go-doc

Testing

PR tests

New tests cover the changes: no

Description for the changelog

Bugfix: Bump Go to 1.19.1 for CVE-2022-27664

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sparrc sparrc requested a review from a team as a code owner September 22, 2022 21:14
@fierlion
Copy link
Member

There are a lot of whitespace changes -- can you update the description to explain how these ended up in the change set?

@sparrc
Copy link
Contributor Author

sparrc commented Sep 23, 2022

There are a lot of whitespace changes -- can you update the description to explain how these ended up in the change set?

yes, updated

Copy link
Contributor

@YashdalfTheGray YashdalfTheGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The io/ioutil to os changes are awesome! Thanks for making those!

@sparrc sparrc merged commit a27d30c into aws:dev Sep 26, 2022
@sparrc sparrc deleted the bump-go-1-19-1 branch September 26, 2022 22:04
yinyic pushed a commit that referenced this pull request Sep 29, 2022
* Bump Go version to 1.19.1

pickup the fix for https://nvd.nist.gov/vuln/detail/CVE-2022-27664

* make goimports

* make goimports -f init_Makefile

* fix seelog xml

* deprecate ioutil
@ubhattacharjya ubhattacharjya added this to the 1.64.0 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants