Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests for cgroup v2 #3491

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

prateekchaudhry
Copy link
Contributor

@prateekchaudhry prateekchaudhry commented Nov 28, 2022

Summary

  • ECS Agent already supports cgroupv2, but some unit tests failed to work with cgroupv2 support. This PR makes due changes to the tests by checking for the cgroup version support running and verifying the correct addresses/values depending on the support.
  • Additionally, also this PR also changes the GH Actions tests to run on ubuntu-latest which now points to ubuntu 22.04 to keep up with the latest OS.

Testing

Verified the following commands succeeded for cgroupv1 and cgroupv2 support on ubuntu 20.04 and ubuntu 22.04
make test-silent
make test-init
New tests cover the changes:
yes

Description for the changelog

Fix unit tests for cgroup v2

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@prateekchaudhry prateekchaudhry changed the title [Do not Review] Use ubuntu 20.04 for linux unit tests Fix unit tests for cgroups v2 Dec 1, 2022
@prateekchaudhry prateekchaudhry changed the title Fix unit tests for cgroups v2 Fix unit tests for cgroup v2 Dec 1, 2022
@chienhanlin
Copy link
Contributor

Thanks for fixing this! Can we add a brief summary to the PR? Thanks!

@YashdalfTheGray YashdalfTheGray merged commit d1fa74b into aws:dev Dec 5, 2022
@singholt singholt mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants