Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC bugfix: generate network bindings for SC containers #3513

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

singholt
Copy link
Contributor

@singholt singholt commented Dec 12, 2022

Summary

bug-fix: generate network bindings for SC containers

Implementation details

With port range mapping project, we changed the way network bindings are generated for a container.
We generate a port set that stores singular ports for a container, while giving dockerPortMap to Docker.

The fix here is to update this set for a SC container too. This ensures that we generate network bindings related to a SC container as well, in addition to application container.

Testing

Built an ecs-agent manually and ran SC tasks to verify that network bindings for SC container are now populated as expected. We're also working on running the functional tests related to service connect.

New tests cover the changes: no

Description for the changelog

bug-fix: generate network bindings for SC containers

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@singholt singholt changed the title WIP SC bugfix: generate network bindings for SC containers Dec 12, 2022
@singholt singholt marked this pull request as ready for review December 12, 2022 23:53
@singholt singholt requested a review from a team as a code owner December 12, 2022 23:53
With port range mapping project, we changed the way network bindings are generated for a container.
We use a port set that stores singular ports for a container – the fix is to update this set for SC container too.
Copy link
Contributor

@YashdalfTheGray YashdalfTheGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about PR on huddle, walked through it. Looks good.

@YashdalfTheGray YashdalfTheGray merged commit 4cc3613 into aws:dev Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants