Update the default option for ECS_DISABLE_METRICS on Windows to match the code
#3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
approved these changes
Mar 22, 2023
rajal-amzn
approved these changes
Mar 22, 2023
rajal-amzn
reviewed
Mar 22, 2023
|
So we do set this as |
singholt
approved these changes
Mar 29, 2023
SreeeS
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an error in the README file where we had specified the default
trueon Windows forECS_DISABLE_METRICS. I looked in the code and it doesn't seem like we actually set it totrue, i.e. actually disable metrics collection on Windows.Just updated the README file to match.
Description for the changelog
fix: changed disable metrics default for Windows in the README to false
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.