Add more tests for v2, v3, and v4 container metadata endpoints #3708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
task_server_setup_test.go
are currently initialized withv2.ContainerResponse.Network
field that must be set tonil
before the struct is used for assertions. Fix this by setting the field tonil
when the struct is initialized.testTMDSRequest
function that may be used to test happy and error cases of all metadata endpoints. This function removes the need to set up TMDS, setup mocks, perform JSON unmarshalling, and perform assertions in each test function, thus greatly simplifying TMDS testing.TestV2ContainerMetadata
,TestV3ContainerMetadata
, andTestV4ContainerMetadata
functions for testing v2, v3, and v4 container metadata endpoints, respectively. These test functions include all happy and error cases. Remove existing tests for these endpoints as they are covered in the new test functions.Testing
New tests cover the changes: yes
Description for the changelog
Add more tests for v2, v3, and v4 container metadata endpoints
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.