Integrate with tcsHandler in ecs-agent module #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realmonia
force-pushed
the
dockerIntegration
branch
from
8f882f8 to
1986f20
Compare
Realmonia
force-pushed
the
dockerIntegration
branch
4 times, most recently
from
bf87632 to
4fda649
Compare
Realmonia
force-pushed
the
dockerIntegration
branch
7 times, most recently
from
6674636 to
24cc036
Compare
Realmonia
changed the title
chienhanlin
reviewed
Jun 29, 2023
chienhanlin
reviewed
Jun 29, 2023
chienhanlin
reviewed
Jun 29, 2023
chienhanlin
reviewed
Jun 29, 2023
chienhanlin
previously approved these changes
Jul 5, 2023
prateekchaudhry
previously approved these changes
Jul 6, 2023
Realmonia
dismissed stale reviews from prateekchaudhry and chienhanlin
via
b695ba9
Realmonia
force-pushed
the
dockerIntegration
branch
from
9a2fa75 to
b695ba9
Compare
prateekchaudhry
previously approved these changes
Jul 7, 2023
RichaGangwar
approved these changes
Jul 7, 2023
prateekchaudhry
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate with the tcsHandler (and its extension) in ecs-agent module we created in #3731 and remove tcsHandler from agent module. Also slightly modified
reporter, so it works with current existing agent unit test.Implementation details
See summary.
Testing
New tests cover the changes: yes
Description for the changelog
Integrate with tcsHandler in ecs-agent module
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.