Add eni and appmesh ecs-agent module, and refactor eni to have a more general naming "NetworkInterface" with expanded attributes #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realmonia
force-pushed
the
netLibDataModels
branch
3 times, most recently
from
2c99e1a to
bab3dac
Compare
Realmonia
force-pushed
the
netLibDataModels
branch
6 times, most recently
from
5102c69 to
4f93caa
Compare
Realmonia
changed the title
Realmonia
force-pushed
the
netLibDataModels
branch
3 times, most recently
from
340a48e to
eb92019
Compare
Realmonia
force-pushed
the
netLibDataModels
branch
from
eb92019 to
aba6a65
Compare
|
Do we plan to remove eni and appmesh from the |
|
Is there any significance of the field |
Yes! We will remove those after Fargate changes its integration code. Currently it is directly inherited by Fargate agent code base.
This is a field used by Fargate and potentially used by future network library. |
prateekchaudhry
approved these changes
Aug 15, 2023
mythri-garaga
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds eni and appmesh to
netlib/modelpath toecs-agentmodule, as well as renamingenitonetworkInterfaceto accommodate expanded attributes to support Fargate better.Implementation details
netlib/modelpath inecs-agentmodule.eniandappmeshto above path. I didn't do direct move but duplication first, because Fargate is directly importing and inheriting the definitions on mentioned two models.Testing
New tests cover the changes: N/A
Existing github testing workflow passed.
Manual testing: this is a model change (including naming change), I did a test on agent update to make sure it does not break our data model persistence mechanism.
After an in place update (run a task, run
make release, thensudo systemctl restart ecs), a new non-“omitempty” fieldDNSMappingListshows up in boltdb, without breaking anything else.Description for the changelog
Add eni and appmesh ecs-agent module and refactor eni to have a more general naming
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.