Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing static checks #3810

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix failing static checks #3810

merged 1 commit into from
Jul 18, 2023

Conversation

danehlim
Copy link
Contributor

@danehlim danehlim commented Jul 18, 2023

Summary

Motivation:

  1. This PR was raised: Update metrics interface to couple metric completion and publish #3803
  2. Then this PR was raised (without the changes in the above PR taken into account): Add ACS attach resource responder to ecs-agent #3807
  3. PR Update metrics interface to couple metric completion and publish #3803 was merged
  4. PR Add ACS attach resource responder to ecs-agent #3807 was then subsequently successfully rebased and merged via Github, but now this line of code is not valid: https://github.com/aws/amazon-ecs-agent/blob/dev/ecs-agent/acs/session/attach_resource_responder.go#L72
  5. Static checks are now failing

This PR addresses the line of code mentioned above to fix the failing static checks.

Implementation details

Update usage of metrics Entry interface Done method in attach resource responder.

Testing

Existing PR tests

Description for the changelog

Fix failing static checks

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim marked this pull request as ready for review July 18, 2023 18:02
@danehlim danehlim requested a review from a team as a code owner July 18, 2023 18:02
@sparrc sparrc merged commit 77309f2 into aws:dev Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants