-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ACS session to ecs-agent module and refactor #3887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realmonia
reviewed
Sep 6, 2023
Realmonia
reviewed
Sep 6, 2023
Realmonia
reviewed
Sep 6, 2023
Realmonia
reviewed
Sep 6, 2023
Realmonia
reviewed
Sep 6, 2023
Realmonia
reviewed
Sep 6, 2023
timj-hh
reviewed
Sep 6, 2023
danehlim
force-pushed
the
ecs-agent-acs-session
branch
from
September 7, 2023 18:22
c7e9aa2
to
102b9fb
Compare
Realmonia
approved these changes
Sep 7, 2023
timj-hh
reviewed
Sep 7, 2023
timj-hh
reviewed
Sep 7, 2023
timj-hh
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move ACS session to ecs-agent module and refactor associated code.
Implementation details
agent/acs/handler/acs_handler.go
->ecs-agent/acs/session/session.go
Start
method and other related methods it calls now take in acontext.Context
in favor of storing acontext.Context
as a struct field in the whole session itselfStart
method also now returns the error code returned by the context, which provides meaningful information about why the Session ended (as opposed to current behavior, where the method always returnsnil
)agentVersion
,agentHash
,dockerVersion
,inactiveInstanceCB()
function,PayloadMessageHandler
,CredentialsMetadataSetter
,ENIHandler
,ResourceHandler
,ManifestMessageIDAccessor
,SequenceNumberAccessor
,TaskComparer
,TaskStopper
,metrics.EntryFactory
, and*wsclient.WSClientMinAgentConfig
agent/acs/handler/acs_handler_test.go
->ecs-agent/acs/session/session_test.go
agent/app/agent.go
Start
method is handled)Testing
Unit, integration, and functional tests.
New tests cover the changes: yes
Description for the changelog
Move ACS session to ecs-agent module and refactor
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.