Move container/task statuses to ecs-agent module #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
force-pushed
the
task-container-statuses
branch
from
f66f13d to
e8a4277
Compare
amogh09
approved these changes
Sep 25, 2023
singholt
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move container/task statuses to ecs-agent module. This is required for future changes in ecs-agent module that depend on these statuses. If these statuses are not moved, then in the future a dependency cycle could be introduced in which the ecs-agent module depends on agent module while the agent module already depends on ecs-agent module.
Implementation details
agent/api/container/status/toecs-agent/api/container/status/agent/api/task/status/toecs-agent/api/task/status/Testing
Existing unit, integration, and functional tests.
New tests cover the changes: N/A
Description for the changelog
Move container/task statuses to ecs-agent module
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.