Decouple ENI in ecs-agent/ AttachmentStateChange #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj-hh
approved these changes
Nov 7, 2023
RichaGangwar
reviewed
Nov 8, 2023
Thanks for taking a look! No, we should not need to update any mocks here since no interfaces that we generate mocks from were modified. We can also confirm this by running |
RichaGangwar
approved these changes
Nov 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update AttachmentStateChange in ecs-agent module to take into account the ENI decoupling from #3969 (since that pull request did not update the AttachmentStateChange type that was added to ecs-agent module as part of #3943).
Implementation details
Same as summary.
Testing
Unit, integration, and functional tests.
New tests cover the changes: no, but existing test modified
Description for the changelog
Decouple ENI in ecs-agent/ AttachmentStateChange
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.