-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpc contract credfetcher #4043
Update grpc contract credfetcher #4043
Conversation
57dc6af
to
6859451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please update the PR description to include explanation about the new methods added to the contract?
72bfdb5
to
a32e88c
Compare
1. Add client contract to credfetcher 2. Add the associated unit tests
c51d783
to
cb872c6
Compare
ecs-agent/gmsacredclient/credentialsfetcher/credentialsfetcher_grpc.pb.go
Show resolved
Hide resolved
@amogh09 wrote:
+1, this would help a lot for reviewers/future reference |
Summary
Added new client contracts to communicate with credentials-fetcher to support gMSA Linux
Implementation details
The changes are to add the client support to have integration with new contracts exposed by credentials-fetcher
Testing
Added unit tests both positive and negative test case for the functionality. Also manually tested ensuring ECS gMSA works as expected
New tests cover the changes:
Description for the changelog
Adding new contracts to credentials-fetcher client to support gMSA linux
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.