Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc contract credfetcher #4043

Conversation

saikiranakula-amzn
Copy link
Contributor

@saikiranakula-amzn saikiranakula-amzn commented Nov 27, 2023

Summary

Added new client contracts to communicate with credentials-fetcher to support gMSA Linux

Implementation details

The changes are to add the client support to have integration with new contracts exposed by credentials-fetcher

Testing

Added unit tests both positive and negative test case for the functionality. Also manually tested ensuring ECS gMSA works as expected

New tests cover the changes:

Description for the changelog

Adding new contracts to credentials-fetcher client to support gMSA linux

The new contracts accept the credentialspec s3 arn input, and the associated task execution role credentials to process the request and generate associated kerberos tickets

Does this PR include breaking model changes? If so, Have you added transformation functions?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@amogh09 amogh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please update the PR description to include explanation about the new methods added to the contract?

@saikiranakula-amzn saikiranakula-amzn force-pushed the update_grpc_contract_credfetcher branch from 72bfdb5 to a32e88c Compare December 1, 2023 00:54
1. Add client contract to credfetcher
2. Add the associated unit tests
@saikiranakula-amzn saikiranakula-amzn force-pushed the update_grpc_contract_credfetcher branch from c51d783 to cb872c6 Compare December 1, 2023 17:34
@danehlim
Copy link
Contributor

danehlim commented Dec 1, 2023

@amogh09 wrote:

Can we please update the PR description to include explanation about the new methods added to the contract?

+1, this would help a lot for reviewers/future reference

@saikiranakula-amzn saikiranakula-amzn merged commit 3f42e13 into aws:dev Dec 1, 2023
36 checks passed
@danehlim danehlim mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants