Certs base #4079
Closed
Certs base #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stable-20211201 is based on the current `oldstable` release, `bullseye`, and has an older ca-certificates package (20210119), whereas 20240110 is based on the current `stable` release, `bookworm`, and has a more up to date ca-certificates package (20230311)
Current versions of the ca-certificates package no longer include CNNIC_ROOT certificates, so the separate trimming step is no longer necessary
|
Thanks for updating this @lewayne-aws, looks like there's no difference in the outputted certs config file from the updated container. I think we should merge this to stop doing the CNNIC hackaround and best practice of using an up-to-date container dependency. Just as an aside, for reference on why to remove the CNNIC cert, see https://blog.mozilla.org/security/2015/03/23/revoking-trust-in-one-cnnic-intermediate-certificate/ I tested by building the container before and after this change and outputting the ca-certificates.conf file: |
sparrc
approved these changes
Apr 23, 2024
|
Our codebuild CI project is having issues finding this source code for some reason, so I've cherry-picked the commits and reopened as #4153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR, ecs-agent will pull in a newer ca-certificates package, from the current stable release of Debian, and will no longer attempt to remove the CNNIC certs, which have already been removed upstream
Implementation details
The
stable-20211201-slimimage that is currently used to sourceca-certificatesis running Debian'sbullseyerelease (a.k.a.oldstable), and as such, pulls in ca-certificates version 20210119. By using a newer stable image (stable-20240110-slim), the newer ca-certificates version 20230311 will be used.I also noticed that the certs Dockerfile was performing an extra step to attempt to remove the
CNNIC_ROOTcertificate, however this cert no longer appears to be present in current versions of the package.Testing
make testwas run. There were some upgrade related tests that failed there (TestCNIPluginVersionUpgrademainly), however it appears to be the same result from an unmodifiedmasterbranch.New tests cover the changes: no; There is no change in functionality to test
Description for the changelog
Update ca-certificates
Does this PR include breaking model changes? If so, Have you added transformation functions?
No functionality changes were made.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.