Specifically set the CW endpoint when using awslogs as log driver for specifc regions #4143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will provide a short term workaround regarding issues with using
awslogs
as the log driver type for new/specific regions. Essentially, the Docker version that ECS Agent is using is unable to resolve the correct Cloudwatch endpoint on its own for new regions which should be done via the AWS SDK Go package. This was fixed/support for new regions were added in AWS SDK Go V2 which will need a docker upgrade in order to so. As a short term solution, we'll explicitly set these endpoints as theawslogs-endpoint
log option when invoking docker to run the task containers for the new regions until a long term solution is available.Here's an example of the errors we're encountering
Implementation details
awslogs
duringcreateContainer
whenever we're in the new regions. Then set theawslogs-endpoint
as one of thehostConfig.LogConfig.Config
that we're passing into docker.Testing
TestCreateContainerAwslogsLogDriver
Launched a new task in one of the new regions with the following definition:
Outcome:
Manually executing docker run (in PDX):
New tests cover the changes: Yes
Description for the changelog
Explicitly pass in awslogs-endpoint for new regions as a short term workaround
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.