Simplify ContainerStatus.BackendStatusString() method #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dStatusString method
amogh09
changed the title
timj-hh
approved these changes
May 7, 2024
Yiyuanzzz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#4167 introduced
ContainerStatus.BackendStatusString()method that maps internal container status to a backend-recognized container status string. This method takes container steady state as a parameter which still adds coupling between internal container status and backend-recognized status string. To decouple the two further, this PR removes the parameter and un-deprecatesBackendStatusmethod which serves a different purpose of mapping internal container status to an internal container status which is eligible for STSC.Testing
New tests cover the changes: no
Description for the changelog
Does this PR include breaking model changes? If so, Have you added transformation functions?
Enhancement: Simplify ContainerStatus.BackendStatusString() method
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.