Update TMDS response for restart tracker #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
approved these changes
May 15, 2024
danehlim
approved these changes
May 15, 2024
Merged
jiuchoe4
pushed a commit
to saurabhc123/amazon-ecs-agent
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating TMDS container level response to make
RestartCountan int pointer and removeLastRestartedAt. The latter is a remnant that we no longer need.RestartCountwill be omitted from the json response as an int because 0 is the 'null' value for integers. By making it a pointer, the TMDS response will only omit if the count is null.It was decided earlier to store
restartTrackerwith non-pointer types so these will be left alone, as the code becomes awkward otherwise.Implementation details
N/A.
Testing
make testDescription for the changelog
Update TMDS response for container restarts
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.