Add SourcesToFilter support for network-blackhole-port fault #4408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
SourcesToFilter
parameter to network-blackhole-port fault. This field is needed to supply IPs that should be protected from the fault. This will be helpful for certain sidecar containers such as FIS sidecar to protect their service related endpoints from getting impacted by the fault. We already have this for network-latency and network-packet-loss faults.Implementation details
SourcesToFilter
toNetworkFaultRequest
SourcesToFilter
and adds an ACCEPT rule for each source to the fault chain.SourcesToFilter
if the fault is for egress traffic and the port of the fault matches TMDS port. TMDS access is blocked for the task only by egress faults so we need to protect TMDS IP only for egress faults.Testing
Ran a bunch of manual tests for host and awsvpc network mode tasks. Verified that
SourcesToFilter
field are still accessible after an egress network-blackhole-port fault is injected. Other IP on the fault's port are not accessible.New tests cover the changes: yes
Description for the changelog
Enhancement: Add SourcesToFilter support for network-blackhole-port fault
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.