Update image registry of base container images from Dockerhub to ECR #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
force-pushed
the
fix-external-images
branch
from
d558de5 to
d3c457d
Compare
mye956
reviewed
Nov 1, 2024
mye956
approved these changes
Nov 1, 2024
harishxr
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates source image registry of various base images we use from Dockerhub to ECR in
AmazonLinuxLegacy2018branch.Following images were updated -
misc/certs/Dockerfile-FROM debian:stable-20201012toFROM public.ecr.aws/docker/library/debian:stable-20240110-slim- this is because the older image no longer works (same change was made for dev branch in Update ca-certs base image #4153)misc/fluentd/Dockerfile-FROM fluent/fluentd:v1.11.5-1.0toFROM public.ecr.aws/docker/library/fluentd:v1.14.0-1.0- following Update fluentd container to 1.14, use ECR #3101, older image version is not available in ECRmisc/pause-container/Dockerfile-FROM gcc:7.3.0 as buildtoFROM public.ecr.aws/docker/library/gcc:11.2.0 as build- Older gcc is not available in ECR, following Pull gcc build image from public ECR, bump version #3108Testing
Built all the images locally.
New tests cover the changes:
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.