Upgrading vendored AWS SDK release to v1.8.19 #786
Conversation
agent/gogenerate/awssdk.go
Outdated
| @@ -39,7 +41,7 @@ var typesOnlyTplAPI = template.Must(template.New("api").Parse(` | |||
| {{ end }} | |||
| `)) | |||
|
|
|||
| const copyrightHeader = `// Copyright 2014-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| const copyrightHeader = `// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
minor: Can you modify this to get the year string in code so that we don't have to update this every year?
|
@petderek can you also verify that on a long running Agent built from this code, metrics continue to show up in the ECS console? |
agent/gogenerate/awssdk.go
Outdated
| @@ -41,7 +42,7 @@ var typesOnlyTplAPI = template.Must(template.New("api").Parse(` | |||
| {{ end }} | |||
| `)) | |||
|
|
|||
| const copyrightHeader = `// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| const copyrightHeaderTemplate = `// Copyright 2014-%v Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Can you change to %d instead of %v so that it's more specific?
|
@aaithal I verified metrics are working after letting the agent run overnight and launching some tasks just now. Did you have any other concerns with metrics? |
|
@petderek thanks. Nope, just wanted to verify that they show up. |
| @@ -13,4 +13,4 @@ | |||
|
|
|||
| package model | |||
|
|
|||
| //go:generate go run ../../gogenerate/awssdk.go -typesOnly=false | |||
There was a problem hiding this comment.
Where is the codegen tag being used?
There was a problem hiding this comment.
The SDK team started using the codegen tag in their generators, so we need this in order to run the generate commands. I put a +build codegen in awssdk.go as well.
There was a problem hiding this comment.
Got it. In the spirit of "self documenting code", can you either modify the commit message or add a comment to state the same?
* Refactor http request code to use public API * Adding "codegen" build constraint * Regenerating ECS and ECR client code * Minor fixes
Summary
Update the vendored AWS SDK
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes: no
Description for the changelog
Update AWS SDK release v1.8.19
Licensing
This contribution is under the terms of the Apache 2.0 License: yes