Reduce the acs inactivity timeout to 1 minute #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please check the boxes in the summary and also add an explanation as to why the jitter was removed in the commit message body? Thanks |
aaithal
reviewed
Aug 3, 2017
| @@ -45,8 +45,7 @@ import ( | |||
| const ( | |||
| // heartbeatTimeout is the maximum time to wait between heartbeats | |||
| // without disconnecting | |||
| heartbeatTimeout = 5 * time.Minute | |||
| heartbeatJitter = 3 * time.Minute | |||
| heartbeatTimeout = 1 * time.Minute | |||
There was a problem hiding this comment.
Why was the jitter removed?
There was a problem hiding this comment.
@richardpen Can you explain the removal of the jitter here for posterity?
There was a problem hiding this comment.
I have added it back in the new commit after understanding why it was there.
richardpen
force-pushed
the
reduce-acs-disconnection-period
branch
from
20f2c51
to
7d33b69
Compare
aaithal
approved these changes
Aug 7, 2017
jhaynes
approved these changes
Aug 7, 2017
This will reduce the acs disconnection period, the maximum
disconnection period of acs would be 2 minutes before agent
try to connect to acs again.
richardpen
force-pushed
the
reduce-acs-disconnection-period
branch
from
7d33b69
to
af6e51e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will reduce the acs disconnection period, the maximum disconnection period of acs would be 1 minute before agent try to connect to acs again. This should mitigate the issue #781.
Implementation details
Change the default heartbeat timeout from 5 minute + random(3minutes) to 1 minute.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
This contribution is under the terms of the Apache 2.0 License:
yes