Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge from dev to master branch
Make release is failing on amazon-ecs-agent when we update the submodules.
The Error message is:
This change is to include
-buildvcs=false
flag to the go build in Make file.This error occurred after we updated the amazon-ecs-cni-plugins sub module in amazon-ecs-agent to pull the latest commit due to this change in golang: golang/go#37475
Implementation details
Added
-buildvcs=false
flag in Make file.-buildvcs=false
excludes version control information when golang version is >= 1.18.Testing
make unit-test
make release on ecs-agent repo for go version 1.18.8 and 1.15
New tests cover the changes: no
Description for the changelog
bug-Fixed failed make release on ecs-agent repo
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.