fix: ensure custom endpoint monitor obeys refresh rate #1175
Conversation
aaron-congo
changed the title
| waitUntilEndpointsDeleted(client); | ||
| } | ||
|
|
||
| private static void waitUntilEndpointsDeleted(RdsClient client) { |
There was a problem hiding this comment.
This used to be called after deleting the test custom endpoint after all tests in the file had been completed. I removed it to save some time (note that the custom endpoint still gets deleted, we are just no longer waiting for it to fully complete the deletion). Each custom endpoint will have a unique ID, so even though other tests could start running while the custom endpoint is still being deleted, no other tests should be require it to be fully deleted before running. Let me know if you think I should add it back
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
| @@ -188,13 +186,18 @@ public void run() { | |||
| } | |||
| } | |||
| } catch (InterruptedException e) { | |||
| LOGGER.info(Messages.get("CustomEndpointMonitorImpl.interrupted", new Object[]{ this.customEndpointHostSpec })); | |||
| LOGGER.info( | |||
There was a problem hiding this comment.
nit: Log level fine is probably better in this case.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.