Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure abort interrupts running queries #1182

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: ensure abort interrupts running queries #1182

merged 4 commits into from
Nov 12, 2024

Conversation

aaron-congo
Copy link
Contributor

Description

  • fixes Expected Behavior of Abort with the AWS JDBC Wrapper #1173
  • abort was not interrupting queries because the plugin manager was locked during query execution and abort was not included in ASYNCHRONOUS_METHODS. This PR fixes this problem by allowing abort to be executed asynchronously
  • after allowing asynchronous abort, the exception triggered by abort was triggering failover. To avoid this, closedExplicitly is set when abort is called and checked in shouldExceptionTriggerConnectionSwitch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Nov 7, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@aaron-congo aaron-congo merged commit 8f962b6 into main Nov 12, 2024
6 checks passed
@aaron-congo aaron-congo deleted the issue-1173 branch November 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected Behavior of Abort with the AWS JDBC Wrapper
2 participants