Add support for samplingRate #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 413e594.
cgchinmay
reviewed
Nov 11, 2021
cgchinmay
reviewed
Nov 11, 2021
|
@suniltheta What is the behavior with envoy image older than 1.19.1.1 ? |
|
Envoy image prior to 1.19.1.1, there will be no effect even if we set this value. The X-ray sampling will still pick default value of 0.05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
aws/aws-app-mesh-roadmap#371
Description of changes:
Add back support for samplingRate
This reverts commit 413e594. #522
This support was originally added in #512
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.